Workarea 3.2.5
Replace all spaces with dashes in WORKAREA.string.dasherize()
Use the /g option on the replacement regular expression so that all spaces are accounted for in a dasherized String with JavaScript.
Issues
Pull Requests
- 3235
Commits
Fix CSS selectors in email template layout
Update syntax so email layout CSS applies to the correct elements.
Issues
Pull Requests
Commits
Fix view test setup logic
View (helper) tests were failing because they didn't include the same setup code as integration and system tests, resulting in a pollution of the global state. Add logic for disabling Sidekiq callbacks and ActionMailer emails in helper tests.
Issues
Pull Requests
Commits
Remove unused focus-ring CSS cruft
Since we no longer use a custom focus-ring for all focusable elements in v2.x, this reset code and extra CSS for maintaining that architecture got left behind. In v3.x, we only offer a focus-ring to custom UIs.
Issues
Pull Requests
Scroll browser to the bottom of the page in pagination system tests
Changing the default grid widths on category browse/search pages can potentially cause a failure stemming from paginated content that needs to be clicked, but isn't visible in the viewport at that time. This resolves those potential failures by scrolling the headless browser to the bottom of the page so it can see the elements that need to be clicked.
Issues
Pull Requests
Commits
Prevent duplicate shipping charge
We added a data-disable-with attribute to checkout buttons in v3.1 and above, but never backported the fix to v3.0, where the problem was still occurring. This should backport that fix and resolve a potential race condition where shipping charges can double on a checkout.
Issues
Pull Requests
Commits
New Address dialog opens in the middle of viewport on iOS Safari
For older iOS Safari users, the "New Address" dialog will sometimes open in the middle of the page and cause the top half of the form to get cut off. Apply a max-height of 90vh in order to center the dialog in the viewport as it opens. We also needed to add the !important flag because jQuery UI Dialog applies an inline style that overrides our customization.
Issues
Pull Requests
Commits
Fix style guide links for components that don't have their own page
There are certain components that do not have their own dedicated page for styles. Make sure these can be navigated to by way of adding a potential custom anchor to the #link_to_style_guide helper, allowing components to define the anchor for a link on the page they live on.
Issues
Pull Requests
Commits
Output category name instead of ID in product rules activity feed
When creating product rules that key off of a Catalog::Category, ensure that the category name is being found and rendered rather than its BSON Object ID. This improves the legibility of the category activity feed.
Issues
Pull Requests
Commits
Fix 500 error when editing help articles
While testing help article editing, we discovered that the activity feed partials for help articles had the wrong route helper method referenced. The correct helper method is now being used, and thus a 500 error has been prevented from view in the admin when help articles are created or saved.
Issues
Pull Requests
Commits
Reject promise when src is undefined on WORKAREA.image
Discovered in ONETHEME-111, this prevents a promise never getting resolved if a src URL is undefined.